Use pf's anchor to load the rules for nat and port forwarding #8

fabianfreyer · 2017-10-01T11:44:50Z

Fixes #1

fabianfreyer · 2017-10-01T11:48:15Z

lib/vagrant-bhyve/driver.rb

@@ -146,6 +146,28 @@ def load_module(module_name)
 	end
      end

+      def check_or_create_default_pfconf(ui)
+        if execute(true, "test -s /etc/pf.conf") != 0


Arguably, /etc/pf.conf should not be hardcoded here but maybe taken from the pf_rules rcvar.

fabianfreyer · 2017-10-01T11:48:59Z

lib/vagrant-bhyve/driver.rb

+        if execute(true, "test -s /etc/pf.conf") != 0
+	  ui.warn I18n.t("vagrant_bhyve.action.vm.boot.create_default_pfconf")
+
+          # probably this could be done in a nicer way with open and puts...


I'll replace this with a File.open(...) block when I'm rebasing the next time.

fabianfreyer · 2017-10-01T11:51:15Z

lib/vagrant-bhyve/driver.rb

-	  pf_file.puts "set skip on #{bridge_name}"
+        check_or_create_default_pfconf(ui)
+	# set up bridge pf anchor
+        pf_bridge_conf = "/usr/local/etc/pf.#{bridge_name}.conf"


Arguably this should also be somewhere in @data_dir, as it's not really permanent configuration...

update gemfile

b0e4d64

fabianfreyer commented Oct 1, 2017

View reviewed changes

fabianfreyer added 2 commits October 2, 2017 22:43

Use anchors for pf configuration

d20451e

More verbose error messages for bridge handling

2b47ada

fabianfreyer force-pushed the pf-anchor branch from 10c2902 to 2b47ada Compare October 2, 2017 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pf's anchor to load the rules for nat and port forwarding #8

Use pf's anchor to load the rules for nat and port forwarding #8

fabianfreyer commented Oct 1, 2017 •

edited

Loading

fabianfreyer Oct 1, 2017

fabianfreyer Oct 1, 2017

fabianfreyer Oct 1, 2017

Use pf's anchor to load the rules for nat and port forwarding #8

Are you sure you want to change the base?

Use pf's anchor to load the rules for nat and port forwarding #8

Conversation

fabianfreyer commented Oct 1, 2017 • edited Loading

fabianfreyer Oct 1, 2017

Choose a reason for hiding this comment

fabianfreyer Oct 1, 2017

Choose a reason for hiding this comment

fabianfreyer Oct 1, 2017

Choose a reason for hiding this comment

fabianfreyer commented Oct 1, 2017 •

edited

Loading